Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed UnitInput value not being set correctly in monitoring #12438

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

eva-vashkevich
Copy link
Member

@eva-vashkevich eva-vashkevich commented Oct 30, 2024

Summary

Fixes #12436

Fixed 'Override Group Interval' and 'Wait to fire for' fields when creating Prometheus rule.

Occurred changes and/or fixed issues

During vue migration, .includes usage inside set became corrupted.

Technical notes summary

Areas or cases that should be tested

Make sure that 'Override Group Interval' and 'Wait to fire for' fields can be set correctly:

Install monitoring chart
Once chart installed successfully goto Monitoring->Advanced->PromethuesRules->Create Rule.
Create prometheus rules and add alerting rules with "wait to fire for" and "Override Group Interval" values.

Areas which could experience regressions

None

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

momesgin
momesgin previously approved these changes Oct 30, 2024
Copy link
Member

@momesgin momesgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codewise lgtm, I tried to test it on my local but my instance has been unreliable today.

UPDATE: I was able to test it on another env and the fix works as expected 🚀

nwmac
nwmac previously approved these changes Oct 31, 2024
@nwmac nwmac dismissed stale reviews from momesgin and themself via adf86ce October 31, 2024 09:43
@nwmac nwmac merged commit 3c808b4 into rancher:master Oct 31, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants