Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.10] Fleet Improvements #12375

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Oct 28, 2024

Summary

Fixes #12232

Occurred changes and/or fixed issues

  • Performance Fix
    • go back to using git repo status cluster ready / desired stats instead of costly clusterResourceStatus (churn can call this a LOT)
    • Improve load time of fleet cluster detail page
  • Bug Fix
    • Using targetClustersReady and targetClusters doesn't seem to work in some cases, revert back to previous
  • General Fixes
    • Fix weird fleet cluster list column alignment

Areas or cases that should be tested

As per issue

Areas which could experience regressions

  • Git repo detail page loads fine (on navigation and refresh)
  • Fleet Dashboard page shows correct stats for
    • clusters ready - now matches repo list's cluster stats
    • bundles ready - no change (except 0 now displays as such, rather than ?)
    • resources ready - no change (except 0 now displays as such, rather than ?)

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

- Performance Fix
  - go back to using git repo status cluster ready / desired stats instead of costly clusterResourceStatus (churn can call this a LOT)
  - Improve load time of fleet cluster detail page
- Bug Fix
  - Using targetClustersReady and targetClusters doesn't seem to work in some cases, revert back to previous
- General Fixes
  - Fix weird fleet cluster list column alignment
@richard-cox richard-cox added this to the v2.10.0 milestone Oct 28, 2024
@rancher-ui-project-bot rancher-ui-project-bot bot modified the milestones: v2.10.0, v2.11.0 Oct 28, 2024
- avoid 0 showing as `?` - e.g. `0 || ?`
@richard-cox richard-cox changed the title Fleet Improvements [2.10] Fleet Improvements Oct 28, 2024
@richard-cox richard-cox modified the milestones: v2.11.0, v2.10.0 Oct 28, 2024
@richard-cox richard-cox mentioned this pull request Oct 28, 2024
7 tasks
@richard-cox richard-cox marked this pull request as ready for review October 29, 2024 10:17
@richard-cox richard-cox merged commit df953cd into rancher:master Oct 29, 2024
33 checks passed
@richard-cox richard-cox deleted the fleet-improvements branch October 29, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SURE-9111] Clusters Ready missmatch between Gitrepos and Dashboard pages in Continuous Delivery
2 participants