Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harvester shell integration - add translations #12353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

torchiaf
Copy link
Member

@torchiaf torchiaf commented Oct 24, 2024

Summary

Contributes to #12347

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@a110605
Copy link
Contributor

a110605 commented Oct 25, 2024

Do you mind update Add-On to Add-on?
This is what we did in harvester PR

image

@nwmac nwmac added the shell PRs/Issues that relate to a shell release rather than being needed for a dashboard release label Oct 29, 2024
codyrancher
codyrancher previously approved these changes Oct 31, 2024
Copy link
Contributor

@codyrancher codyrancher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like someone else above needs to approve this. Even though I'm okay with expanding the contractions and replacing things like & I don't know if others are okay with that. I guess worst case scenario we could always revert back if an issue arises.

a110605
a110605 previously approved these changes Nov 1, 2024
Copy link
Contributor

@a110605 a110605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for current translation change.

Signed-off-by: Francesco Torchia <[email protected]>
@torchiaf torchiaf force-pushed the feature/harvester-shell-integration-5 branch from 67af2e5 to a2d63f9 Compare November 5, 2024 12:03
@torchiaf torchiaf dismissed stale reviews from codyrancher and a110605 via 9d6a9f0 November 5, 2024 14:51
@torchiaf torchiaf force-pushed the feature/harvester-shell-integration-5 branch from 6dd5a17 to a2d63f9 Compare November 5, 2024 16:16
@gaktive gaktive modified the milestones: v2.10.0, v2.11.0 Nov 5, 2024
@torchiaf torchiaf force-pushed the feature/harvester-shell-integration-5 branch from a2d63f9 to 1f1da06 Compare November 6, 2024 13:37
@torchiaf torchiaf changed the title Harvester shell integration - translations Harvester shell integration - add translations Nov 6, 2024
@torchiaf torchiaf requested a review from a110605 November 6, 2024 15:20
@torchiaf
Copy link
Member Author

torchiaf commented Nov 6, 2024

@a110605 I removed the existing labels changes and moved them in a separate PR for simplicity. Can you approve it again ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shell PRs/Issues that relate to a shell release rather than being needed for a dashboard release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants