Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting ssh or https for repos in fleet #7518

Closed
kwwii opened this issue Nov 22, 2022 · 2 comments · Fixed by #7648
Closed

Allow setting ssh or https for repos in fleet #7518

kwwii opened this issue Nov 22, 2022 · 2 comments · Fixed by #7648

Comments

@kwwii
Copy link
Contributor

kwwii commented Nov 22, 2022

Fleet should allow for both ssh or https protocols for repos.

Here's a simple mockup of how this should look:
protocol-example

@kwwii
Copy link
Contributor Author

kwwii commented Nov 28, 2022

There was an error in the new drop-down input label - this provides clarity:
fleet.png

The new protocol drop-down should have two values, "ssh://" and "https://". The default selection is https://.

@Josh-Diamond
Copy link

Per discussion/decision made here:
#7648 (comment)

This enhancement will consist of a banner being added, stating the following:
Enter a valid HTTPS or SSH URL to a git repository.

This enhancement is NOT expected to add protocol dropdown w/ https or ssh options.


Ticket #7518 - Test Results - ✅

With Docker on a single-node instance:

Verified on Rancher v2.7-17e5bb595bc7d6d9280dd40280b4e82b21903790-head:

  1. Fresh install of Rancher v2.7-head
  2. Navigate to Continuous Delivery > GitRepos > Add Repository
  3. Verified - Enter a valid HTTPS or SSH URL to a git repository. banner is present and accurate

Screenshot:
Screenshot 2023-02-13 at 11 56 30 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants