Deprecate infrastructure ref #542
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkaempf
added
kind/enhancement
kind/bug
anmazzotti
force-pushed
the
deprecate_infrastructure_ref
branch
3 times, most recently
from
cd38c61 to
d6c1173
Compare
Signed-off-by: Andrea Mazzotti <[email protected]>
anmazzotti
force-pushed
the
deprecate_infrastructure_ref
branch
from
d6c1173 to
2f60670
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kind/feature
kind/bug
What this PR does / why we need it:
This is a (dirty) attempt of using the v1beta1 newly added
RKE2ControlPlane.Spec.MachineTemplate.InfrastructureRefand fixes the API to be used properly with ClusterClass.Note that this counts as an API change, however this is an attempt of getting away with it without a version bump.
The controlplane controller tries to catch and patch all missed conversions for this reason.
Also note that this PR assumes that v1beta1
RKE2ControlPlane.Spec.MachineTemplate.InfrastructureRefandRKE2ControlPlane.Spec.InfrastructureRefare equal. However since the former is currently ignored, it is not guaranteed that they will match.Still a draft, missing proper testing and test coverage.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #341
Special notes for your reviewer:
Checklist: