Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failing e2e tests #260

Merged
merged 2 commits into from
Feb 19, 2024
Merged

fix: failing e2e tests #260

merged 2 commits into from
Feb 19, 2024

Conversation

furkatgofurov7
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 commented Feb 8, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #242

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@furkatgofurov7 furkatgofurov7 added area/testing Indicates an issue related to test kind/bug Something isn't working labels Feb 8, 2024
Signed-off-by: Furkat Gofurov <[email protected]>
@richardcase
Copy link
Contributor

Just tried this locally and the e2e passes 🎉 Thanks @furkatgofurov7

@richardcase richardcase changed the title WIP: Fix failing e2e tests fix: failing e2e tests Feb 19, 2024
@richardcase richardcase merged commit 1563d86 into rancher:main Feb 19, 2024
8 checks passed
@Danil-Grigorev Danil-Grigorev mentioned this pull request Feb 19, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Indicates an issue related to test kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e] Test have been failing for a long time
3 participants