Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump versions and change template for e2e #203

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

richardcase
Copy link
Contributor

What this PR does / why we need it:

The e2e tests have been failing for a very long time. This change makes the following changes:

  • Bumps CAPI to 1.6.x so that we can use the new feature of CAPD to supply a custom LB config
  • Updates the e2e template in 2 ways:
    • Supply a custom LB config so the RKE2 join port is exposed
    • Disable the cloud controller

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #151

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • adds or updates e2e tests

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
richardcase Richard Case
Signed-off-by: Richard Case <richard.case@outlook.com>
@richardcase richardcase added area/testing Indicates an issue related to test kind/bug Something isn't working labels Nov 17, 2023
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small non-blocking question:

@richardcase richardcase merged commit 8862f02 into rancher:main Nov 17, 2023
8 checks passed
@richardcase richardcase deleted the fix_e2e branch November 17, 2023 14:29
@furkatgofurov7 furkatgofurov7 mentioned this pull request Feb 21, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Indicates an issue related to test kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E tests are failing consistently
2 participants