CI: BATS: Make k8s/helm-install-rancher pass on macOS #7069
Commits on Jun 19, 2024
-
- Use long arguments for commands where available. - Tell shfmt that we're linting for bats (for *.bash). Signed-off-by: Mark Yen <[email protected]>
-
BATS: k8s/helm-install-rancher: Look for incremental progress
This test is prone to failing on macOS CI, possibly because the runners are somewhat slower. Try to improve this by _not_ waiting for the helm chart deployment to finish, but instead manually checking for key log lines in the containers until they are actually ready. This also does a couple other things to help this test pass: - Pre-pull the rancher image to ensure the image pulling doesn't make the machine busier than necessary. - Update the arguments for the cert-manager chart (removing deprecated usage). Signed-off-by: Mark Yen <[email protected]>
-
BATS: when capturing logs, allow missing config file
In case we got called right after a factory reset. Signed-off-by: Mark Yen <[email protected]>
-
BATS: k8s/rancher: Set replicas to 1
By default it is set to 3, which is unneeded in CI. Signed-off-by: Mark Yen <[email protected]>
-
BATS: helm-install-rancher: Drop uninstall
Since we'll be doing factory resets before each Kubernetes version (or in the next test file, if it's the last version), there's no need to do an uninstall that could take significant time. Signed-off-by: Mark Yen <[email protected]>
-
BATS: k8s/helm-install-rancher: Disable ramdisk
This test needs a lot of RAM (to run Rancher Manager); disable ramdisk to avoid hitting swap. Signed-off-by: Mark Yen <[email protected]>
-
This is a Kubernetes deployment name that is spawned as part of Rancher Manager. Signed-off-by: Mark Yen <[email protected]>
-
BATS: k8s/helm-install-rancher: Address review comments
Signed-off-by: Mark Yen <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.