Upgrade Electron to v30 #7000
Merged
Upgrade Electron to v30 #7000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not expected to build; it's just a checkpoint. Signed-off-by: Mark Yen <[email protected]>
`BrowserView` is now fully deprecated; replace its functionality using `WebContentsView` instead. - Change the layout so that we determine the extensions view size by using a `<div>` of the desired size (hidden behind other content). - Since `WebContentsView` has no `setAutoResize`, manually resize the extensions view when the main content view size has changed, as well as on zoom change. - Rewrite zoom implementation so it adjusts the zoom of all child views directly instead of using keyboard events. - Use custom menu even on development builds (so that our new zoom code can be correctly triggered). Signed-off-by: Mark Yen <[email protected]>
Electron-builder doesn't yet support asar integrity on Windows; disable it so that the packaged version can start up. This is new on Windows in Electron 30 (previously it was only possible on macOS). Signed-off-by: Mark Yen <[email protected]>
Nino-K
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades Electron; fixes #6744
There were surprisingly few issues this round. I recommend reviewing commit-by-commit.
Filed #6999 to re-enable Windows ASAR integrity (because it's not supported on current electron-builder).