E2E: fix test for WSL integration #5832
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mook-as
force-pushed
the
wsl/integration-e2e
branch
3 times, most recently
from
dc5053e
to
f53e4c5
Compare
Signed-off-by: Mark Yen <[email protected]>
This avoids assumptions about what is available inside the target distros (we no longer require /bin/sh and ln). Signed-off-by: Mark Yen <[email protected]>
Stop using mock-wsl, and use the real thing instead. Signed-off-by: Mark Yen <[email protected]>
Signed-off-by: Mark Yen <[email protected]>
mook-as
force-pushed
the
wsl/integration-e2e
branch
from
f53e4c5
to
dafba72
Compare
ericpromislow
requested changes
Nov 2, 2023
| // Wait for the window to actually load (i.e. transition from | ||
| // app://index.html/#/preferences to app://index.html/#/Preferences#general) | ||
| await preferencesWindow.waitForURL(/Preferences#/i); | ||
| expect(prefWin.wsl.tabIntegrations).toHaveCount(1); |
| return preferencesWindow; | ||
| } | ||
|
|
||
| test.beforeAll(({ wslError }) => { |
There was a problem hiding this comment.
Where does the wslError argument come from?
There was a problem hiding this comment.
The fixture, from line 33. (Or, I guess, 26 if you want to talk types). I do need to update the PR to have a relevant comment here, though.
| RD_MOCK_WSL_DATA: path.join(workdir, 'config.json'), | ||
| }, | ||
| function registerDistro(distro: string, files: Record<string, string> = {}, version = 2) { | ||
| test.beforeAll(async() => { |
There was a problem hiding this comment.
So everytime you call registerDistro you create a new before-hook?
There was a problem hiding this comment.
Yep, but that made more sense when I had it also call afterAll after each distro. At this point that makes less sense, and I should probably reorganize this a bit.
|
FYI: Finally got the e2e test to run and partially pass, but: |
|
(I'll still need to split this into multiple PRs first anyway) Do you have the logs from that run? Given that the received string is |
This was referenced Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #5830