Modify Upgrade Responder client code to prepare for future changes

[adamkpickering]

Closes #4036.

[mook-as]

Basically just for lint issues.

[jandubois]

Sorry, I haven't finished my review, but I'm running out of time right now.

I did find one or two places that look like bugs though, so submitting partial review now.

[adamkpickering]

Marking as ready for review because it's getting too big. Also, it was mostly reviewed already and I don't want to confuse anyone by making more changes (more than I already have).

I'm planning on adding wslVersion to the request body in a future PR.

[jandubois]

Sorry, I haven't finished the testing, and am offline for the next 4 days, so wanted to leave a few notes:

I'm running influxdb in a separate VM, and the upgrade responder locally.

I set the following environment variables:

export RD_FORCE_UPDATES_ENABLED=1
export RD_MOCK_VERSION=1.6.0
export RD_UPGRADE_RESPONDER_URL=http://localhost:8314/v1/checkupgrade

Using the lower mock version is so that the upgrade responder can suggest newer versions that actually exist as Github releases and can be downloaded.

I added the following patch so that the version is passed to the upgrade responder:

--- pkg/rancher-desktop/main/update/LonghornProvider.ts
+++ pkg/rancher-desktop/main/update/LonghornProvider.ts
@@ -350,7 +350,16 @@ export default class LonghornProvider extends Provider<LonghornUpdateInfo> {
       }
     }

-    const queryResult = await queryUpgradeResponder(this.configuration.upgradeServer, this.updater.currentVersion);
+    let currentVersion = this.updater.currentVersion;
+
+    if (process.env.RD_MOCK_VERSION) {
+      const mockVersion = semver.coerce(process.env.RD_MOCK_VERSION);
+
+      if (mockVersion) {
+        currentVersion = mockVersion;
+      }
+    }
+    const queryResult = await queryUpgradeResponder(this.configuration.upgradeServer, currentVersion);
     const { latest, unsupportedUpdateAvailable } = queryResult;
     const requestIntervalInMinutes = queryResult.requestIntervalInMinutes || defaultUpdateIntervalInMinutes;
     const requestIntervalInMs = requestIntervalInMinutes * 1000 * 60;

I do get the following error on the console:

(node:37083) UnhandledPromiseRejectionWarning: TypeError: Cannot read properties of undefined (reading 'find')
    at LonghornProvider.checkForUpdates (/Volumes/ThunderBlade/suse/rd/dist/app/background.js:37395:48)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async LonghornProvider.getLatestVersion (/Volumes/ThunderBlade/suse/rd/dist/app/background.js:37425:23)
    at async MacUpdater.getUpdateInfoAndProvider (/Volumes/ThunderBlade/suse/rd/node_modules/electron-updater/out/AppUpdater.js:319:19)
    at async MacUpdater.doCheckForUpdates (/Volumes/ThunderBlade/suse/rd/node_modules/electron-updater/out/AppUpdater.js:333:24)
    at async triggerUpdateCheck (/Volumes/ThunderBlade/suse/rd/dist/app/background.js:37883:24)

[jandubois]

Thanks, LGTM

[jandubois]

Re-approving after rebase