Handle paths in nerdctl compose subcommands
#1332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mook-as
requested changes
Jan 27, 2022
src/go/nerdctl-stub/parse_args.go
Outdated
Comment on lines
281
to
282
| subcommands := []string{"build", "config", "down", "kill", "logs", "ps", "pull", "push", "up"} | ||
| for _, sc := range subcommands { |
There was a problem hiding this comment.
Suggested change
| subcommands := []string{"build", "config", "down", "kill", "logs", "ps", "pull", "push", "up"} | |
| for _, sc := range subcommands { | |
| for _, sc := range []string{"build", "config", "down", "kill", "logs", "ps", "pull", "push", "up"} { |
We never use the slice for anything else.
Some of the commands have a 3-level structure: `nerdctl COMMAND options.... SUBCOMMAND options...` This change will WSL-convert paths that appear in the second set of options. Signed-off-by: Eric Promislow <[email protected]>
Signed-off-by: Eric Promislow <[email protected]>
ericpromislow
force-pushed
the
1213-process-subcommand-args
branch
from
b0f35b0 to
ef88a07
Compare
|
Subsumed by #1355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the commands have a 3-level structure:
nerdctl COMMAND options.... SUBCOMMAND options...This change will WSL-convert paths that appear in the second set
of options.
Signed-off-by: Eric Promislow [email protected]