Lima: Darwin: Don't always use en0 for bridged network. #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some systems, en0 is not connected; in that case, we need to find the correct network to bridge onto. This implements the detection. Signed-off-by: Mark Yen <[email protected]>
- Only pick host networks with IP addresses. rancher-sandbox#1136 (comment) - Make a backup of unexpected configurations we're clobbering. rancher-sandbox#1136 (comment) - Only make bridges for interfaces that exist. rancher-sandbox#1136 (comment) Signed-off-by: Mark Yen <[email protected]>
jandubois
approved these changes
Dec 17, 2021
mattfarina
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems, en0 is not connected; in that case, we need to find the correct network to bridge onto. This implements the detection.
Fixes #1125.
This is #1136 cherry-picked onto the release branch.