Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modules to 0.85.0 and add storage/filestorage extension #13

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

jaehnri
Copy link
Member

@jaehnri jaehnri commented Sep 20, 2023

The storage/filestorage extension is necessary to persist a filelog's tail offset as mentioned in rancher/opni#1708.

plugin/logging:

Notice this version has been tested with Opni. Whenever this version is used, the following line must be removed:
https://github.com/rancher/opni/blob/f12c766d6bbcbed43218223c742d58ccf3dbae99/pkg/resources/preprocessor/workloads.go#L73

plugin/metrics:

Apparently, metrics are running fine:

image

However, there might be something wrong with Prometheus endpoint scraping, as per the aggregator logs:

2023-09-20T18:46:15.569Z	warn	internal/transaction.go:123	Failed to scrape Prometheus endpoint	{"kind": "receiver", "name": "prometheus/discovered", "data_type": "metrics", "scrape_timestamp": 1695235575564, "target_labels": "{__name__=\"up\", instance=\"10.42.0.44:8443\", job=\"apiserver\"}"}

@jaehnri
Copy link
Member Author

jaehnri commented Sep 20, 2023

In this PR, if we don't want to update to 0.85.0 due to the possible breaking changes, we can also opt to only add the filestorage extension. However:

@alexandreLamarre
Copy link
Collaborator

Has metrics collection been tested with v0.85? In particular need to make sure the opni admin grafana dashboards work with the OTEL driver

@jaehnri
Copy link
Member Author

jaehnri commented Sep 20, 2023

@alexandreLamarre ah, no. Might need some help with that...

@jaehnri jaehnri requested a review from kralicky September 20, 2023 18:48
@jaehnri jaehnri merged commit 6874ecf into main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants