Set the client namespace on uninstall

[Itxaka]

We are missing reading from the chart annotations as well,
or maybe thats not gonna be implemented?

We are missing this piece to be able to clean up the resources properly but probably missing obtaining the namespace from annotattions which is quite bigger....and would probably benefit from extraction some generic methods...

Partial fix: #77

Signed-off-by: Itxaka [email protected]

[viccuad]

Looks good! I think this is it. And I don't think there's any need to look for annotations; the uninstall command works on releases on the store, not on charts, so there's no annotations to be looked at!

[viccuad]

I think we should add some tests to catch the problems (maybe out of this PR). Adding tests to cmd/hypper/uninstall_test.go doesn't give us anything, as those check for command output. I thought adding pkg/action/uninstall_test.go shouldn't be needed, but as we are using our own Config instead of the one inside of helm/pkg/action/install.go, then we should write tests testing our Config.

[Itxaka]

I think we should add some tests to catch the problems (maybe out of this PR). Adding tests to cmd/hypper/uninstall_test.go doesn't give us anything, as those check for command output. I thought adding pkg/action/uninstall_test.go shouldn't be needed, but as we are using our own Config instead of the one inside of helm/pkg/action/install.go, then we should write tests testing our Config.

Do we really? Like, are we doing something any special that setNamespace (which should be tested of course)? The rest is basically the same as helm and should be covered by helm testing on their side no?