Fix namespace set on upgrade command #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Itxaka
added
bug
dragonchaser
previously requested changes
Mar 9, 2021
viccuad
requested changes
Mar 9, 2021
Itxaka
added
WIP
Itxaka
force-pushed
the
fix_upgrade_namespace
branch
from
52cd46e
to
b670b6b
Compare
Itxaka
added
ready for review
viccuad
previously requested changes
Mar 11, 2021
Itxaka
added
WIP
viccuad
reviewed
Mar 12, 2021
Itxaka
force-pushed
the
fix_upgrade_namespace
branch
from
46da112
to
683bfee
Compare
|
Either this or it wazs already broken but passing the |
|
My mistake, seems that --release-name works, it was just missing tests...adding those... |
Itxaka
force-pushed
the
fix_upgrade_namespace
branch
from
683bfee
to
bfc471c
Compare
added 2 commits
March 15, 2021 11:40
Namespace was not being set via annotations properly for the upgrade command nor the install command called from the upgrade. It also fixes a problem with an extra args being passed to the upgrade Name method which is nonsense as we onyl use the chart for that Also adds tests for the action upgrade Signed-off-by: Itxaka <[email protected]>
We were mocking the hypper timestamper, but meanwhile when we loaded helm actions it would overwrite the timestamper with a real one This worked until now because we were not using golden files with timestamp on them to be checked against the auto-timestamper dates but were instead created a fixed timestamp (see status_test.go) thus not hitting this issue. This should fix any future problems with testing and generating auto fixed timestamps Signed-off-by: Itxaka <[email protected]>
Itxaka
force-pushed
the
fix_upgrade_namespace
branch
from
bfc471c
to
54309b6
Compare
Itxaka
added
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace was not being set via annotations properly
for the upgrade command nor the install command called
from the upgrade
Fixes: #73
Signed-off-by: Itxaka [email protected]