Add new upgrade command #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Itxaka
force-pushed
the
upgrade_command
branch
6 times, most recently
from
c4f7e90
to
8cec68e
Compare
dragonchaser
suggested changes
Mar 4, 2021
Itxaka
force-pushed
the
upgrade_command
branch
2 times, most recently
from
53d8945
to
b53b732
Compare
added 2 commits
March 5, 2021 10:00
Lifted completely from helm, no changes other that removing autocompletion as we dont have that yet Signed-off-by: Itxaka <[email protected]>
Instead of using directly the helmCli settings use our own composite type Signed-off-by: Itxaka <[email protected]>
added 3 commits
March 5, 2021 11:26
Picks the name from the chart based of Annotations then falls back to the default name in the chart.yaml This allows us to only pass the chart path to upgrade. If this is called on a new chart install also works as expected by setting the chartname before calling install Signed-off-by: Itxaka <[email protected]>
Allows to override the release name via a flag --release-name STRING which will ignore any annotations or names in the chart.yml file Adds the ReleaseName field to the hypper Upgrade struct to keep track of the release name. Works both on Upgrade and NewInstall Signed-off-by: Itxaka <[email protected]>
As we automatically obtaine the release name, the upgrade tests needs some small fixes to work as expected Signed-off-by: Itxaka <[email protected]>
Itxaka
added
ready for review
viccuad
requested changes
Mar 5, 2021
viccuad
requested changes
Mar 5, 2021
viccuad
requested changes
Mar 5, 2021
- Use composite type for History - Fix comments that refer to upgrade name - Missing doc comments - Missing license header Signed-off-by: Itxaka <[email protected]>
dragonchaser
reviewed
Mar 8, 2021
dragonchaser
approved these changes
Mar 8, 2021
viccuad
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lifted completely from helm, no changes other that removing
autocompletion as we dont have that yet
fixes: #54