Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query options w/ context - feedback requested #135

Open
kardianos opened this issue Nov 28, 2016 · 1 comment
Open

query options w/ context - feedback requested #135

kardianos opened this issue Nov 28, 2016 · 1 comment

Comments

@kardianos
Copy link

I'm looking at issue golang/go#13067 .

Now that you can pass a context to the various query methods, what do you think about supporting setting options on queries through context? I'm unsure if that would be a good or bad idea. But either way, feedback appreciated on the issue.
@tgulacsi
Copy link
Collaborator

Sure. Just be selective, what's useful and what's just a maintenance hog.

WithPrefetchRowCount(Context, int) Context
WithFetchArraySize
WithCLOB(Context, ora.GoColumnType) Context

All seems useful, and could help with proper documentation.

tgulacsi added a commit that referenced this issue Dec 1, 2016
@tgulacsi
add WithStmtCfg - tackles #135
7c9d054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tgulacsi @kardianos