Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for multiple search and added some tests #497

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Added support for multiple search and added some tests #497

merged 4 commits into from
Sep 30, 2024

Conversation

jakin010
Copy link
Contributor

Description

Their was no support for searching multiple types

Motivation and Context

#496

Type of change

  • [x ] New feature (non-breaking change which adds functionality)

How has this been tested?

  • [ z] test_search_album: testing normal search
  • [z ] test_search_multiple_types: testing if multiple types is returned

Is this change properly documented?

Yes

ramsayleung
ramsayleung reviewed Sep 27, 2024
View reviewed changes
Copy link
Owner

@ramsayleung ramsayleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribute, I left a few nitpick comments.

CHANGELOG.md Outdated Show resolved Hide resolved
src/clients/base.rs Outdated Show resolved Hide resolved
@ramsayleung ramsayleung merged commit c84d7bd into ramsayleung:master Sep 30, 2024
7 checks passed
@ramsayleung
Copy link
Owner

Thanks for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramsayleung ramsayleung ramsayleung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakin010 @ramsayleung