Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade rspotify to 0.11.5 #308

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Conversation

ramsayleung
Copy link
Owner

Description

Upgrade rspotify to v.0.11.5

Motivation and Context

Fix #307

Dependencies

None

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

How has this been tested?

All CI checks should pass.

Is this change properly documented?

Yes

Copy link
Collaborator

@marioortizmanero marioortizmanero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to bump the other crates' version numbers

@ramsayleung
Copy link
Owner Author

ramsayleung commented Mar 29, 2022

Oooh, my bad, I forgot to upgrade the version number of rspotify-http, everything should work now.

@marioortizmanero marioortizmanero merged commit 0b4f3aa into master Mar 29, 2022
@marioortizmanero marioortizmanero deleted the ramsay_upgrade_to_v0.11.5 branch March 29, 2022 10:11
@apprehensions
Copy link

crates.io still reports 0.11.4, is it slow?

@ramsayleung
Copy link
Owner Author

ramsayleung commented Mar 29, 2022

This PR just upgraded the version number in cargo.toml to v0.11.5, we also need to publish the new version to crates.io. Then we have a Github Action job to handle this workflow, which is triggered by creating a new git tag.

PS:
The CI flow passed, new version has been published to crates.io, everything should work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

push 0.11.5
3 participants