Make FullTrack.id optional #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramsayleung
reviewed
Nov 20, 2021
| .start_uris_playback(uri, device, offset, position) | ||
| .await | ||
| .unwrap(); | ||
| if let Some(uri) = uri { |
There was a problem hiding this comment.
Is it necessary to extract the uri variable? It seems that uri will not be used later
There was a problem hiding this comment.
It's used in start_uris_playback
|
Everything else looks good to me. |
ramsayleung
approved these changes
Nov 20, 2021
|
Whoops, I have to add these changes to the changelog before this is merged. We should probably add a reminder for this in the PR template. |
Great point! |
|
Just updated the changelog, this is ready to be merged. I'll make a new PR with the reminder about the changelog. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #279
Dependencies
None
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The CI passes perfectly.