Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is_playable always being None #260

Merged
merged 3 commits into from
Sep 28, 2021
Merged

Conversation

marioortizmanero
Copy link
Collaborator

@marioortizmanero marioortizmanero commented Sep 25, 2021

Description

As #190 explains, is_playable was always None because the market parameter was missing in these endpoints.

I suggest merging #259 first, as I wrote this over that branch by mistake.

Motivation and Context

Closes #190

Dependencies

None

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Check out the test I modified. Can be ran with, for example:

$ cargo test --no-default-features --features=client-ureq,ureq-rustls-tls -- --ignored test_current_user_saved_tracks_add

@ramsayleung ramsayleung merged commit d0add84 into percent-search Sep 28, 2021
@marioortizmanero marioortizmanero deleted the is-playable-tests branch September 28, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_playable field is always Option::None
2 participants