Fix IDs #241
Closed
Fix IDs #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this in favor of #243 |
ramsayleung
reviewed
Sep 11, 2021
| pub type EpisodeIdBuf = IdBuf<Episode>; | ||
|
|
||
| /// A Spotify object id of given [type](crate::enums::types::Type). | ||
| /// A Spotify object ID of a given [type](crate::enums::types::Type). |
There was a problem hiding this comment.
I am a little confused that what's difference between the old Id wrapper and the new Id wrapper, it seems the only difference is that alias type declarations are moved into macro sealed_idtypes and an Unknown type has been added?
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This closes #203. It also includes a few more changes about IDs, like using them in
rspotify-model, more tests and documenting them thoroughly.Motivation and Context
I've fixed some of the issues I found about IDs. I still need to figure out :
Deserialize<'_>