-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass parameters by reference and use iterators wherever possible #206
Merged
marioortizmanero
merged 11 commits into
master
from
ramsay_pass_parameters_by_reference
Apr 28, 2021
Merged
Pass parameters by reference and use iterators wherever possible #206
marioortizmanero
merged 11 commits into
master
from
ramsay_pass_parameters_by_reference
Apr 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the parameters mostly are passed by value, which means the compiler will
Copy
the parameter when passes them into a method, it's a little inefficient, then pass them by reference instead.Using iterators wherever possible, since it's more atomic and rusty.
Fixed #127
Motivation and Context
Improve the efficiency of this library.
Dependencies
List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?