Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ureq requirement from 1.4.1 to 2.0.0 #174

Merged
merged 3 commits into from
Jan 7, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 4, 2021

Updates the requirements on ureq to permit the latest version.

Changelog

Sourced from ureq's changelog.

1.5.4

  • Fix panic introduced in 1.5.4 on redirects. (#274)

1.5.3

  • Backport: follow redirects non-body request on 307/308 (#253)

1.5.2

  • Remove 'static constraint on Request.send(), allowing a wider variety of types to be passed. Also eliminate some copying. (#205).
  • Allow turning a Response into an Error (#214).
  • Update env_logger to 0.8.1 (#195).
  • Remove convenience method for CONNECT verb (#177).
  • Fix bugs in handling of timeout_read (#197 and #198).

1.5.1

  • Use cookie_store crate for correct cookie handling (#169).
  • Fix bug in picking wrong host for redirects introduced in 1.5.0 (#180).
  • Allow proxy settings on Agent (#178).

1.5.0

  • Add pluggable name resolution. Users can now override the IP addresses for hostnames of their choice (#148).
  • bugfix: Don't re-pool streams on drop. This would occur if the user called response.into_reader() and dropped the resulting Read before reading all the way to EOF. The result would be a BadStatus error on the next request to the same hostname. This only affected users using an explicit Agent (#160).
  • Automatically set Transfer-Encoding: chunked when using send (#86).
  • into_reader() now returns impl Read + Send instead of impl Read (#156).
  • Add support for log crate (#170).
  • Retry broken connections in more cases (should reduce BadStatus errors; #168).

1.4.1

  • Use buffer to avoid byte-by-byte parsing result in multiple syscalls.
  • Allow pooling multiple connections per host.
  • Put version in user agent "ureq/1.4.1".

1.4.0

  • Propagate WouldBlock in io:Error for Response::to_json.
  • Merge multiple cookies into one header to be spec compliant.
  • Allow setting TLSConnector for native-tls.
  • Remove brackets against TLS lib when IPv6 addr is used as hostname.
  • Include proxy in connection pool keys.
  • Stop assuming localhost for URLs without host part.

... (truncated)

Commits
  • 62cf25f Update changelog and Cargo.toml for 1.5.4
  • 23f9b47 [1.x] Fix broken behavior for 308 redirects (#274)
  • 6cc69ba 1.5.3 and CHANGELOG
  • 7d4f794 Only follow 307/308 redirects for methods without a body
  • 2b395e1 Follow 307/308 redirects
  • 165eae3 Update webpki-roots requirement from 0.20 to 0.21 (#247)
  • f69725e Update rustls-native-certs requirement from 0.4 to 0.5 (#248)
  • f1cfea5 Update rustls requirement from 0.18 to 0.19 (#246)
  • c2d4e52 1.5.1
  • 310c14d Update CHANGELOG for 1.5.2. (#216)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 4, 2021
@marioortizmanero marioortizmanero self-assigned this Jan 5, 2021
@marioortizmanero marioortizmanero marked this pull request as draft January 5, 2021 21:51
@marioortizmanero marioortizmanero marked this pull request as ready for review January 5, 2021 23:32
@marioortizmanero
Copy link
Collaborator

This should be ready for a review now. The error handling part is still to be discussed at #137, but we can bump the version in the meanwhile.

fn request<D>(
&self,
request: &mut Request,
mut request: Request,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you like to change the request parameter from &mut to mut?

Copy link
Collaborator

@marioortizmanero marioortizmanero Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ureq's builder pattern no longer uses &mut Request, it's now Request. So instead of using &mut Request and updating the builder with builder.method(), it's now builder = builder.method(), which requires the local request variable to be mutable in the function.

@ramsayleung
Copy link
Owner

merged :)

@ramsayleung ramsayleung merged commit 586f2be into master Jan 7, 2021
@ramsayleung ramsayleung deleted the dependabot/cargo/ureq-2.0.0 branch January 7, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants