Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text hidden behind ToC #397

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Text hidden behind ToC #397

merged 1 commit into from
Feb 26, 2024

Conversation

KashishMistry
Copy link
Member

@KashishMistry KashishMistry commented Feb 23, 2024 •
edited by RyanCoulsonCA
Loading

For #395

Changes

  • CSS changes to ensure chapters.title hides behind ToC correctly, it was showing a bit before

Notes
Before changes:
toc before

After changes:
toc hidden
toc hidden fr

Testing

  1. Close the expanded Table of Contents.
  2. Ensure that there is no text peeking out.

This change is Reviewable

@github-actions GitHub Actions
Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/toc_text/#/en/00000000-0000-0000-0000-000000000000

yileifeng
yileifeng approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KashishMistry)

RyanCoulsonCA
RyanCoulsonCA approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KashishMistry)

@james-rae
Copy link
Member

Peeking_Snowman

szczz
szczz approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KashishMistry)

@yileifeng yileifeng merged commit 8d2b055 into ramp4-pcar4:main Feb 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yileifeng yileifeng yileifeng approved these changes

@szczz szczz szczz approved these changes

@RyanCoulsonCA RyanCoulsonCA RyanCoulsonCA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KashishMistry @james-rae @RyanCoulsonCA @szczz @yileifeng