-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added swipe controls #238
Added swipe controls #238
Conversation
- allowed to change brightness and volume via vertical swipe - seek video is supported too via horizontal swipe - brighntess is saved across restarts in sharedPreferences and will be applied automatically on video load - cool vector icons for all screens
Hi @avently, I'll test it out this weekend and I'll get back to you. |
@avently , great to see you implementing this essential feature!
Could you please note that the scale for the three should better be
exponential rather then linear? Maybe better fixing it now rather then
later getting to it again?
Thanks again!
P.S. maybe leaving brightness linear, but volume and seek definitely
exponential...
|
@ildar you mean you want to skip more than a minute via one swipe? For example, first 10% of the screen width will skip 20 seconds, 20% will skip 1 minute, then 2 minutes, 5 minutes, etc? |
Well done, @avently !! Looks great!! |
Yes, you got it right. As in vlc and such.
|
- seek speed will increase when you'll make swipe longer
@ildar now it's a little bit cooler |
Awesome! :)
|
Hello @avently, thanks for your implementation - looks great. The following is my feedback:
|
Hello @ram-on Other is done. |
Looks good. Thanks |
Found time and made a normal PR with less code than before and adapted to current code base.