Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Meson build system #8

Merged
merged 9 commits into from
Feb 12, 2024
Merged

Add a Meson build system #8

merged 9 commits into from
Feb 12, 2024

Conversation

amontoison
Copy link
Member

@nimgould @dpo @jfowkes

A few comments:

  • How do we compile a single precision version of sifdecode?
  • What should we do with the files local.f, slct_new.f, slct_old.f and slct_older.f?

@nimgould
Copy link
Contributor

I am not sure there is any point in having a single-precision version (other than via sed). Remember that the SIF files themselves assume that evaluations are done in double precision. Sifdecode is a stand-alone package, and unlikely to be used other than as a first step for cutest. The current cutest converts any double remnants to single via sed if needed, and it would not be possible to include c preprocessing into these as the SIF files don't have such a thing.

The local.f slct_new.f, slct_old.f and slct_older.f files are obsolete and can be removed

@dpo
Copy link
Contributor

dpo commented Oct 14, 2023

Great, thank you. Just so things are clear, the builds called “CI” are for the old build system. Some of them fail but that’s ok. Those called “Meson” are the new ones.

@dpo
Copy link
Contributor

dpo commented Oct 14, 2023

On Cirrus, the binaries and libraries are installed to /usr/local/bin (on linux) and /opt/homebrew/bin on macOS.

https://cirrus-ci.com/task/6126501880397824

That’s not what we want. We should be able to install in a user location.

@amontoison
Copy link
Member Author

amontoison commented Oct 14, 2023

On Cirrus, the binaries and libraries are installed to /usr/local/bin (on linux) and /opt/homebrew/bin on macOS.

https://cirrus-ci.com/task/6126501880397824

That’s not what we want. We should be able to install in a user location.

We can install it in a user location with --prefix=.... I use a user location for builds with GHA because we can't install it otherwise. The goal is just to test that we can install without error.

Update: I pushed a commit to install SIFDecode in a user location.

@dpo
Copy link
Contributor

dpo commented Oct 16, 2023

Thank you! In meson.yml, you set up the Intel compilers, but I only see GFortran builds. Do you know why that is?

@amontoison
Copy link
Member Author

amontoison commented Oct 16, 2023

Thank you! In meson.yml, you set up the Intel compilers, but I only see GFortran builds. Do you know why that is?

I forgot to add them.
I pushed a commit to test the Intel compilers.

@amontoison
Copy link
Member Author

@jfowkes Can you add me as a collaborator for ralna/SIFDecode and ralna/CUTEst?
I need an approval everytime that I push a new commit...

@nimgould
Copy link
Contributor

I added you, please check you got the invitation

@amontoison
Copy link
Member Author

Thanks Nick! It works. 👍

@amontoison amontoison merged commit d88115c into ralna:master Feb 12, 2024
10 of 12 checks passed
@amontoison amontoison deleted the meson branch February 12, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants