Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify proc macro validation #85

Merged
merged 1 commit into from
Jul 8, 2023
Merged

simplify proc macro validation #85

merged 1 commit into from
Jul 8, 2023

Conversation

ralexstokes
Copy link
Owner

from the Oak Security audit:

SimpleSerialize trait implements the derive function, which performs some actions on the passed input. One of them is input.data validation, carried out at ssz-rs-derive/src/lib.rs:548.
This function, depending on whether the validation is successful, has the option of returning ValidationState::Validated, or executing plain panic! when it turns out that the data is incorrect.
Consequently, after this action, there is no technical possibility that the state of input.data will still be Unvalidated. This means that the validation performed in ssz-rs-derive/src/lib.rs:550-553 is redundant.

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e37de56) 75.29% compared to head (46b2b4a) 75.29%.

❗ Current head 46b2b4a differs from pull request most recent head 6f63574. Consider uploading reports for the commit 6f63574 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   75.29%   75.29%           
=======================================
  Files          18       18           
  Lines         858      858           
=======================================
  Hits          646      646           
  Misses        212      212           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ralexstokes ralexstokes merged commit 7284f01 into main Jul 8, 2023
@ralexstokes ralexstokes deleted the clean-up-macro branch July 8, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant