Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make no_std build work with serde feature enabled #58

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

aeryz
Copy link
Contributor

@aeryz aeryz commented May 25, 2023

when serde feature is enabled in a no_std build, it fails due to the references to std. This PR makes serde feature compatible with no_std.

Note that thiserror is completely removed because it doesn't support no_std.

Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few questions but generally I'm open to this

ssz-rs/src/list.rs Outdated Show resolved Hide resolved
ssz-rs/src/container.rs Outdated Show resolved Hide resolved
ssz-rs/src/lib.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +29.64 🎉

Comparison is base (2300ff8) 44.28% compared to head (51f852a) 73.93%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #58       +/-   ##
===========================================
+ Coverage   44.28%   73.93%   +29.64%     
===========================================
  Files          20       18        -2     
  Lines        1409      844      -565     
===========================================
  Hits          624      624               
+ Misses        785      220      -565     
Impacted Files Coverage Δ
ssz-rs/src/lib.rs 100.00% <ø> (ø)
ssz-rs/src/list.rs 75.00% <ø> (ø)
ssz-rs/src/serde.rs 70.00% <0.00%> (-30.00%) ⬇️
ssz-rs/src/vector.rs 83.33% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey sorry for the delay here, there is an audit underway and I was trying to minimize how much main differed from the audit target but I'm losing that battle

this looks good!

@ralexstokes ralexstokes merged commit 400a76b into ralexstokes:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants