-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make no_std
build work with serde
feature enabled
#58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few questions but generally I'm open to this
b5ae2fe
to
657972f
Compare
Signed-off-by: aeryz <[email protected]>
Signed-off-by: aeryz <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
===========================================
+ Coverage 44.28% 73.93% +29.64%
===========================================
Files 20 18 -2
Lines 1409 844 -565
===========================================
Hits 624 624
+ Misses 785 220 -565
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey sorry for the delay here, there is an audit underway and I was trying to minimize how much main
differed from the audit target but I'm losing that battle
this looks good!
when
serde
feature is enabled in ano_std
build, it fails due to the references tostd
. This PR makesserde
feature compatible withno_std
.Note that
thiserror
is completely removed because it doesn't supportno_std
.