add potential fix for OOR access on Vector #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note this is in reference to #22 |
|
In reference to #22 I changed it to instead use the .get() method on encoding. To my knowledge there isn't a good way to get the exact reason of the failure so I just added a generic DeserializeError::InvalidRange{range: Range, buffer_length: usize}, |
ralexstokes
reviewed
Apr 24, 2023
ralexstokes
reviewed
Apr 24, 2023
ralexstokes
reviewed
Apr 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the issue this does not use the safe vec::get method, but does emit an already defined DeserializeError. I am open to other options for the easiest way to fix this. If this is a desired approach I can add some other guards where they are needed.