feat(mev-rs): Refactor and Bench Validator Registry State Extension #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice! would like to see numbers from the benchmark the comment about "loading more efficiently" refers to grabbing validator updates from the beacon chain however, and not about the internals of the validator registry here right now, it just grabs the entire val set on each update, when it could be far more clever around just grabbing updates to those validators that had any change in their state across an epoch (for example) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the validator registry state extension and benchmarks distributive vs grouped iterator map construction.
Follow-on work should be done to explore the usage of bijective mappings and more high level architectural enhancements.