-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Electra epoch processing #387
Implement Electra epoch processing #387
Conversation
6f195ab
to
d696fa0
Compare
epoch_processing
module and process_registry_updates()
d696fa0
to
dab86ac
Compare
1bcfb14
to
a4b1d73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work! moving in the right direction
25ee170
to
f47f52f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
left a suggestion, not required but you may like it
also, this PR is missing the updated process_effective_balance_updates
and something that may not be obvious in the context of the spec gen, but we also need the updated definition of process_epoch
im' fine to do these last two in a different PR
0502f08
to
7b2b4d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! there is a weird thing w/ the balance constants (see comment) but otherwise it looks good, nice work
…from calling function
…ocess_pending_consolidations`
b320840
to
193d28f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing!
No description provided.