Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Light Client Structs for Capella and Deneb #323

Closed
wants to merge 2 commits into from

Conversation

ec2
Copy link

@ec2 ec2 commented Feb 1, 2024

No description provided.

@ralexstokes
Copy link
Owner

thanks for this! it seems like there is some crossed wires w/ the cargo version and the formatter though...

if I run cargo +nightly fmt --all locally, it doesn't add all of these changes to the formatting

using rustfmt 1.7.0-nightly (b11fbfbf 2024-02-03)

maybe your local setup wasn't detecting the local rustfmt.toml?

also, I can only find one file to add support for capella definitions -- did you also mean to include deneb changes?

I'd consider opening a new PR with just the changes for capella, and not running the linter without the prescribed config

@ralexstokes
Copy link
Owner

thanks for this! however, I've addressed this in #346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants