Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(capella): implement process_withdrawals #252

Merged
merged 11 commits into from
Sep 21, 2023
Merged

feat(capella): implement process_withdrawals #252

merged 11 commits into from
Sep 21, 2023

Conversation

PatStiles
Copy link
Contributor

closes #250

@PatStiles PatStiles marked this pull request as draft September 18, 2023 22:34
@PatStiles PatStiles marked this pull request as ready for review September 18, 2023 22:49
ralexstokes
ralexstokes requested changes Sep 19, 2023
View reviewed changes
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent!

there are a few things that may not be obvious until someone gets more familiar w/ the conventions of this repo and I've called them out in the feedback

ethereum-consensus/src/capella/spec/mod.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/capella/block_processing.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/capella/spec/mod.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/capella/spec/mod.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/capella/spec/mod.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/capella/block_processing.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/capella/block_processing.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/capella/block_processing.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/capella/block_processing.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/capella/block_processing.rs Outdated Show resolved Hide resolved
ralexstokes
ralexstokes requested changes Sep 19, 2023
View reviewed changes
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice updates! getting there

ethereum-consensus/src/capella/block_processing.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/capella/block_processing.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/capella/block_processing.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/state_transition/error.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/state_transition/error.rs Outdated Show resolved Hide resolved
@ralexstokes
Copy link
Owner

@PatStiles looks good! I tried to fix the merge conflict but now can't update the branch w/ cargo fmt

if you can fix that this should be ready to merge

@PatStiles
Copy link
Contributor Author

PatStiles commented Sep 20, 2023 •
edited
Loading

@ralexstokes I think I got it??? Running cargo +nightly fmt didn't catch it which is strange

@ralexstokes
Copy link
Owner

@PatStiles looks like you may have an older version of cargo +nightly? try rustup update and then run the formatter again

@PatStiles
Copy link
Contributor Author

got it!

ralexstokes
ralexstokes approved these changes Sep 21, 2023
View reviewed changes
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spectacular! thanks for this!!

@ralexstokes ralexstokes merged commit 3c14c21 into ralexstokes:main Sep 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perelyn-sama Perelyn-sama Perelyn-sama left review comments

@ralexstokes ralexstokes ralexstokes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

capella: impl process_withdrawals
3 participants
@PatStiles @ralexstokes @Perelyn-sama