Skip to content

Commit

Permalink
add some comments about skipping and ignoring spec tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ralexstokes committed Mar 27, 2024
1 parent 59a1f87 commit 0f51efc
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions spec-tests/test_meta.rs
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,15 @@ impl TestMeta {
format!("{self}")
}

// Mark this test as "ignored", which does collect it but does not try to run the test.
// If ignored, a test could be implemented in the future but is currently not.
pub fn should_ignore(&self) -> bool {
self.runner.should_ignore()
}

// Skip collecting this test if `true`.
// If not collected, a test is completely ignored from the spec testing
// as it is not currently supported and there is no intention to support in this repo.
pub fn should_skip(&self) -> bool {
let skipped_runner = self.runner.should_skip();
let skipped_forks = matches!(self.fork, Fork::Eip6110 | Fork::Whisk);
Expand Down

0 comments on commit 0f51efc

Please sign in to comment.