Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MALI-1400] Create interfaces for managing notifications and badge numbers #286

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

rleojoseph
Copy link
Collaborator

@rleojoseph rleojoseph commented Jan 9, 2024

Description

  • Added new interfaces for managing notifications & badge numbers

Links

https://jira.rakuten-it.com/jira/browse/MALI-1400

Checklist

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (3104dce) 75.79% compared to head (add793a) 75.23%.

Files Patch % Lines
js-miniapp-bridge/src/notification-bridge.ts 36.84% 12 Missing ⚠️
js-miniapp-bridge/src/common-bridge.ts 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
- Coverage   75.79%   75.23%   -0.57%     
==========================================
  Files          27       29       +2     
  Lines         818      860      +42     
  Branches       65       65              
==========================================
+ Hits          620      647      +27     
- Misses        174      189      +15     
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@munir-rakuten munir-rakuten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rleojoseph rleojoseph enabled auto-merge (squash) January 17, 2024 07:31
@rleojoseph rleojoseph merged commit 8fc3597 into rakutentech:master Jan 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants