Fix blur on overlay also for older Safari #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…op-filter` for Safari support to disable blur on overlay set by revealjs This is a follow up on rajgoel#180 to fix rajgoel#179 also on older safari. `backdrop-filter` is baseline in browser only since september 2024 with safari 18. For older version the `-webkit` variant is required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
-webkit-backdrop-filterequivalent tobackdrop-filterfor Safari support to disable blur on overlay set by revealjsThis is a follow up on #180 to fix #179 also on older safari.
backdrop-filteris baseline in browser only since september 2024 with safari 18. For older version the-webkitvariant is required.This was required to completely fix the chalkboard plugin when updating to Revealjs 5 in our project quarto-dev/quarto-cli#10842
We'll patch our copy but I figured it would be good to have upstream
Context for the change
backdrop-filtersupport: https://caniuse.com/?search=backdrop-filter-webkitprefix where needed when building so the extension needs to opt out both rule so that it works in Safari too.