code-review #36
code-review #36
Conversation
| import { Display } from './Display'; | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Remove extra spaces
| function App() { | ||
|
|
||
| return ( | ||
| <div> |
There was a problem hiding this comment.
Use React fragments instead of empty
|
|
||
| export default function Alert(prop:any):any { | ||
| const {title,description,status}=prop | ||
| //console.log(title) |
There was a problem hiding this comment.
Remove comments if not needed.
| position:'top' | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Add indentation in this whole file.
|
|
||
| // let res= axios.post('https://fine-puce-bison-cap.cyclic.app/cart', book).then((r)=>{ | ||
|
|
||
| // }).catch((e)=>{alert('added succesfully');}) |
There was a problem hiding this comment.
Remove unwanted comments
| @@ -1,52 +0,0 @@ | |||
| import React, { useState } from "react"; | |||
There was a problem hiding this comment.
It is recommended that if you are using typescript, then use typescript for the entire project. Don't use it with the mixture of javascript.
| // }; | ||
| // console.log(order); | ||
| // dispatch(getBooks(paramObj, cat)); | ||
| // }, [location.search]); |
There was a problem hiding this comment.
Remove unnecessary comments from the entire project
| books.map((el) => | ||
| isLoading? <Skeleton height='70vh' />: | ||
| <BookCard key={el.id} book={el} /> | ||
| )} |
There was a problem hiding this comment.
Avoid writing javascript logic inside jsx/tsx. you can make a function outside and then call that function here.
For example:
`function renderBookCards() {
{books.length > 0 &&
books.map((el) =>
isLoading? :
)}
}
// inside jsx
| // return this.price * this.quantity; | ||
| // }, | ||
| // }, | ||
| // ]; |
There was a problem hiding this comment.
Remove unnecessary comments
| // }) | ||
| // } | ||
|
|
||
| const handleRemove = (id: number) => { |
There was a problem hiding this comment.
we can remove this function if it is not used anywhere
|
|
||
| const handleQuantity = (index: number, quan: any) => { | ||
| let newquan = Number(quan.target.value); | ||
| console.log(quan.target.value); |
There was a problem hiding this comment.
Remove console logs from the entire project
| /> | ||
| ))} | ||
| </VStack> | ||
| {/* -----------------------Cart Price Details------------------------------------ */} |
There was a problem hiding this comment.
We can move the Cart price Details section to a sub component and import it here to make this component more readable
| function Loader(){ | ||
| return( | ||
| <VStack spacing={5}> | ||
| <Spinner |
There was a problem hiding this comment.
Fix the indentation of this file and entire project
| </Center> | ||
|
|
||
|
|
||
| </> |
There was a problem hiding this comment.
Is this react fragments really necessary to use here?
| ); | ||
| }; | ||
|
|
||
| interface NavItem { |
There was a problem hiding this comment.
interfaces are recommended to be defined in a new file. Not in the same as the component file
| href?: string; | ||
| } | ||
|
|
||
| const NAV_ITEMS: Array<NavItem> = [ |
There was a problem hiding this comment.
export this static data to some other file and import it from there
| export const NavbarDropdown = () => { | ||
| const navigate = useNavigate(); | ||
|
|
||
| const dropdownData = [ |
There was a problem hiding this comment.
Never put your statis data inside your component. Always put that data outside your component or in a new file and import it from there.
| </Tabs> | ||
| </PopoverBody> | ||
| </PopoverContent> | ||
| </Popover> |
There was a problem hiding this comment.
This file is too big. Ideally, each file should have a maximum of 100 lines. Can break it down into different sub-components.
| {/* Biggest Payday Discount================================= */} | ||
| <br /> | ||
| <br /> | ||
| <br /> |
There was a problem hiding this comment.
Instead of adding 3
tags, can we give margin-bottom or padding-bottom css property?
Please don't merge this branch. This is just a code-review branch to review comments on your code.