Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop and ruby versions, and add rubocop-performance #210

Merged
merged 1 commit into from
Aug 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: 2.1
jobs:
test:
docker:
- image: cimg/ruby:3.2.2
- image: cimg/ruby:3.3.4
auth:
username: $DOCKERHUB_USERNAME
password: $DOCKERHUB_TOKEN
Expand Down Expand Up @@ -32,7 +32,7 @@ jobs:

push_to_rubygems:
docker:
- image: cimg/ruby:3.2.2
- image: cimg/ruby:3.3.4
auth:
username: $DOCKERHUB_USERNAME
password: $DOCKERHUB_TOKEN
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pronto.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.2.2"
ruby-version: "3.3.4"
bundler-cache: true

- name: Setup pronto
Expand Down
4 changes: 2 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ source "https://rubygems.org"

gemspec

gem "bundler", "~> 2.4"
gem "bundler", "~> 2.5"
gem "byebug"
gem "rake", "~> 13.1"
gem "rspec", ">= 3.12"
gem "rspec", ">= 3.13"
gem "rspec_junit_formatter"
2 changes: 1 addition & 1 deletion lib/rf/stylez/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

module Rf
module Stylez
VERSION = "1.1.1"
VERSION = "1.2.0"
end
end
17 changes: 9 additions & 8 deletions rf-stylez.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,13 @@ Gem::Specification.new do |spec|
spec.executables = ["rf-stylez"]
spec.require_paths = ["lib"]

spec.add_runtime_dependency "get_env", "~> 0.2.1"
spec.add_runtime_dependency "pronto", "~> 0.11.2"
spec.add_runtime_dependency "pronto-rubocop", "~> 0.11.5"
spec.add_runtime_dependency "reek", "~> 6.2"
spec.add_runtime_dependency "rubocop", "1.59.0"
spec.add_runtime_dependency "rubocop-rails", "2.23.1"
spec.add_runtime_dependency "rubocop-rspec", "2.26.1"
spec.add_runtime_dependency "unparser", "~> 0.6"
spec.add_dependency "get_env", "~> 0.2.1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.

spec.add_dependency "pronto", "~> 0.11.2"
spec.add_dependency "pronto-rubocop", "~> 0.11.5"
spec.add_dependency "reek", "~> 6.2"
spec.add_dependency "rubocop", "1.65.1"
spec.add_dependency "rubocop-performance", "1.21.1"
spec.add_dependency "rubocop-rails", "2.25.1"
spec.add_dependency "rubocop-rspec", "3.0.4"
spec.add_dependency "unparser", "~> 0.6.15"
end
7 changes: 6 additions & 1 deletion ruby/rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
AllCops:
TargetRubyVersion: 3.2
TargetRubyVersion: 3.3
NewCops: enable
SuggestExtensions: false
Include:
Expand All @@ -20,6 +20,7 @@ inherit_from:
require:
- rf/stylez
- rubocop-rspec
- rubocop-performance
- get_env/cops

# Custom cops
Expand Down Expand Up @@ -62,6 +63,8 @@ Layout/MultilineMethodCallIndentation:
RSpec/NotToNot:
Enabled: true
EnforcedStyle: to_not
RSpec/PredicateMatcher:
Enabled: false

Style/Documentation:
Enabled: true
Expand All @@ -70,6 +73,8 @@ Style/Documentation:
Style/FrozenStringLiteralComment:
Enabled: true
EnforcedStyle: always
Style/NumericLiterals:
Enabled: false
Style/StringLiterals:
Description: 'Checks if uses of quotes match the configured preference.'
StyleGuide: '#consistent-string-literals'
Expand Down
Loading