[RF-22752] Fix argument serializing when enqueuing failed job #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove needless existence check. Both `nil` and `false` respond to `:responds_to?`, but neither respond to `:retries_on?`.
|
/reviewme @rainforestapp/devs @grodowski @pyromaniackeca @jbarber |
jbarber
approved these changes
Oct 27, 2021
|
|
||
| ## Releasing | ||
|
|
||
| Releasing is done in CircleCI via the `push_to_rubygems`, triggered by pushing a tagged commit. To do so, simply [create a new GitHub release](https://github.com/rainforestapp/queue_classic_plus/releases/new). |
There was a problem hiding this comment.
Suggested change
| Releasing is done in CircleCI via the `push_to_rubygems`, triggered by pushing a tagged commit. To do so, simply [create a new GitHub release](https://github.com/rainforestapp/queue_classic_plus/releases/new). | |
| Releasing is done in CircleCI via the `push_to_rubygems`, triggered by pushing a tagged commit. To do so, simply [create a new GitHub release](https://github.com/rainforestapp/queue_classic_plus/releases/new) or run `rake release:source_control_push` |
(untested)
There was a problem hiding this comment.
But then you lose getting the changelog for free! (and you also need to have the Rubygems credentials locally)
There was a problem hiding this comment.
and you also need to have the Rubygems credentials locally
this is incorrect for release:source_control_push, as it just manipulates the SCM:
https://github.com/ruby/ruby/blob/5af3f7f3574c16ec76fb44b21beec17a74f4417a/lib/bundler/gem_helper.rb#L75-L77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retrying a job, we call
failed_job_class.restart_in, wherefailed_job_classis aQueueClassicPlus::Basedescendant, and therefore serializes its arguments. #42 fixed an issue where we weren't deserializing arguments before sending them torestart_in, which meant we'd try to serialize already serialized arguments.However, when enqueuing a failed job, we do not go through
failed_job_class(since we're not enqueuing in the class's standard queue), and therefore do not re-serialize args. Instead we're callingJSON.dumpon the deserialized arguments, which leads to things like"#<SomeClass:0x00007fbf70bc2b68>"getting enqueued. The easy fix is to use the raw (still-serialized) arguments when enqueuing a failed job.