Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RF-31415] Fix setting of version when starting a run #38

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

magni-
Copy link
Contributor

@magni- magni- commented Nov 16, 2023

This is used by the CLI to mark the run as being initiated by the GH Action: https://github.com/rainforestapp/rainforest-cli/blob/v3.5.0/rainforest-cli.go#L106-L110, and broken in 422af7e.

I temporarily enabled the rainforest workflow on this branch to test the fix:

Prior to the fix: https://github.com/rainforestapp/github-action/actions/runs/6884662525/job/18727576457#step:5:25

❌ compared rainforest-cli to rainforest-gh-action

After the fix: https://github.com/rainforestapp/github-action/actions/runs/6884752372/job/18727819110#step:5:25

✅ compared rainforest-gh-action to rainforest-gh-action

@marvin-rfbot
Copy link

marvin-rfbot bot commented Nov 16, 2023

@magni-
Copy link
Contributor Author

magni- commented Nov 16, 2023

/reviewme @rainforestapp/devs

@marvin-rfbot marvin-rfbot bot added the review label Nov 16, 2023
@magni- magni- merged commit 5855f2c into master Nov 16, 2023
1 check passed
@magni- magni- deleted the RF-31415/pp/fix-version-setting branch November 16, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants