Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIM Keyboard Shortcuts for Navigating Update List #1460

Closed
1 task done
stdavis opened this issue Sep 30, 2024 · 2 comments
Closed
1 task done

VIM Keyboard Shortcuts for Navigating Update List #1460

stdavis opened this issue Sep 30, 2024 · 2 comments

Comments

@stdavis
Copy link

stdavis commented Sep 30, 2024


Steps to Reproduce

.ncurc:

n/a

Dependencies:

n/a

Steps:

Run npx npm-check-updates --color --install always --interactive --format group,repo && npm audit fix on any project that has updates.

Current Behavior

The keys j & k do not scroll through the options.

Expected Behavior

j scrolls down and k scrolls up.

This used to work. I don't know at what point it stopped working. I know that this is probably not a big deal but these keys are much easier to use than the arrow keys for those of use who are used to VIM keyboard shortcuts. I'd be willing to help with a PR for this if someone would be kind enough to point me in the right direction on the implementation.

Thanks for the awesome tool!

@raineorshine
Copy link
Owner

raineorshine commented Oct 1, 2024

Thanks, I support this.

The change would have to happen in https://github.com/raineorshine/prompts/tree/ncu. It's the fork of prompts that npm-check-updates uses.

It looks like k and j are mapped to up and down, but apparently isSelect is false. Maybe broke when heading support was added to multiselect mode. Luckily only 14 commits were added so it shouldn't be hard to track down.

https://github.com/raineorshine/prompts/blob/ncu/lib/util/action.js

@raineorshine
Copy link
Owner

Fixed and published in v17.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants