-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡️ Fast wallet switching #940
Conversation
Fixes a bug caused by saving the current address directly to a persisted store
Here's the packed extension for this build: |
Here's the packed extension for this build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast af
code lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Here's the packed extension for this build: |
Here's the packed extension for this build: |
What changed
(Not sure why the persisted store causes the loop, but it doesn't occur if the store isn't persisted)
Screen recordings / screenshots
💡 These videos show the max speed you can switch at — each switch was the result of a number key press
Before:
Screen.Recording.2023-09-13.at.1.57.51.PM.mov
After:
Screen.Recording.2023-09-13.at.1.56.08.PM.mov
What to test
Final checklist
yarn build
).