[BX-919] Consolidated Asset Balances #827
Conversation
|
Here's the packed extension for this build: |
derHowie
changed the title
BX-919 Consolidated Asset Balances
|
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
| cachedUserAssets[values[0].chainId] = parsedAssets; | ||
| } | ||
| } | ||
| queryClient.setQueryData( |
There was a problem hiding this comment.
i see this one is being called inside userAssetsQueryFunction with chainIdsWithErrorsInResponse as chainIds
i'm trying to understand why we save the retry data in cache if there's any chain with failures instead of returning it from userAssetsQueryFunction
i'm thinking there's a retry time in which this method would be called again but we won't be returning the data on time (we would be doing it the next time this method is called), and even we wouldn't be returning this retry cached data at all if addysHttp.get never fails since cached data is just a fallback
There was a problem hiding this comment.
chatted via slack and seems like is not an isssue 👌
…nt of continuous BE failure
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
What changed (plus any additional context for devs)
meta.chain_ids_with_errorsScreen recordings / screenshots
What to test
Make sure user assets behave as usual. You can test the fallback/retry flow by hardcoding
chainIdsWithErrorsInResponseto an array of supported chain ids.Final checklist
yarn build).