Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optionals to prevent crash on bottom actions #822

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

brunobar79
Copy link
Member

@brunobar79 brunobar79 commented Jul 31, 2023

Fixes https://rainbow-me.sentry.io/issues/4338650653/?project=4504012577112064&query=is%3Aunresolved&referrer=issue-stream&stream_index=4
Figma link (if any):

What changed (plus any additional context for devs)

Same as previous PRs where appSession is not available immediately. Adding optionals will prevent the error.

Screen recordings / screenshots

What to test

Final checklist

  • I have tested my changes in a LavaMoat bundle (yarn build).
  • I have tested my changes in Chrome & Brave.
  • If your changes are visual, did you check both the light and dark themes?

@brunobar79 brunobar79 requested a review from a team July 31, 2023 19:42
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-a9adbb09b42fe032348c12216e88774118e78976.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-a9adbb09b42fe032348c12216e88774118e78976.zip

@brunobar79 brunobar79 merged commit 4c5fd7c into master Aug 1, 2023
2 checks passed
@brunobar79 brunobar79 deleted the @bruno/bottom-actions-crash branch August 1, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants