Catch all the trezor init errors #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the packed extension for this build: |
greg-schrammel
approved these changes
Jul 18, 2023
derHowie
approved these changes
Jul 18, 2023
|
Here's the packed extension for this build: |
Merged
BrodyHughes
pushed a commit
that referenced
this pull request
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://rainbow-me.sentry.io/issues/4302749209/?project=4504012577112064&query=is%3Aunresolved&referrer=issue-stream&stream_index=8
Figma link (if any):
What changed (plus any additional context for devs)
I don't want to initialize trezor connect for everyone all the time, so we're doing it on the fly, however it will throw an error if we do it twice. This is why we're now ignoring the error "TrezorConnect it's already initialized" and continue with the execution.
Screen recordings / screenshots
What to test
Final checklist
yarn build).