Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BX-894] wallet selection dropdown action is not fired when clicking public address text #758

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

derHowie
Copy link
Member

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test

Final checklist

  • I have tested my changes in a LavaMoat bundle (yarn build).
  • I have tested my changes in Chrome & Brave.
  • If your changes are visual, did you check both the light and dark themes?

@linear
Copy link

linear bot commented Jul 11, 2023

BX-894 Send: wallet selection dropdown action is not fired when clicking public address text

The wallet display name text does trigger the collapse/uncollapse action, but the behavior for the subline appears to be different and the click does not bubble up to the parent cell

Screenshot 2023-07-10 at 3.55.13 PM.png

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-e8f84c7473031bddcb7f52739b07936e11289c0c.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-4f125875df38200820234ff7a06d848bb8b6c960.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-4f125875df38200820234ff7a06d848bb8b6c960.zip

@derHowie derHowie merged commit 3f62d7c into master Jul 12, 2023
@derHowie derHowie deleted the @chris/send-address-dropdown branch July 12, 2023 14:12
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-3f62d7c83bdfc520d9a78ce65391443f6c2f69a2.zip

greg-schrammel pushed a commit that referenced this pull request Jul 13, 2023
BrodyHughes pushed a commit that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants