Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap settings dismiss on click outside #743

Merged
merged 6 commits into from
Jul 14, 2023

Conversation

greg-schrammel
Copy link
Contributor

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test

Final checklist

  • I have tested my changes in a LavaMoat bundle (yarn build).
  • I have tested my changes in Chrome & Brave.
  • If your changes are visual, did you check both the light and dark themes?

@greg-schrammel greg-schrammel marked this pull request as draft July 10, 2023 14:21
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-67e475d00ca6041b8c48ead6774b6b9d62315612.zip

@greg-schrammel greg-schrammel marked this pull request as ready for review July 10, 2023 16:12
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

should we do the same for swaps review?

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-41572a87cdc5efc05a2d9dee02746835798f5fe5.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-447e6993cda54b828a553195e32e4f38cd5b89f1.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-a0904e97aa255e836dea22cfbfb9403725e6ab85.zip

@greg-schrammel greg-schrammel merged commit 3b904b1 into master Jul 14, 2023
@greg-schrammel greg-schrammel deleted the dismiss-on-click-outside branch July 14, 2023 14:35
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-3b904b13a586077eae4d3033840ab41bc1adfed9.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants