Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BX-638 & BX-637 #734

Merged
merged 10 commits into from
Jul 10, 2023
Merged

Fix BX-638 & BX-637 #734

merged 10 commits into from
Jul 10, 2023

Conversation

BrodyHughes
Copy link
Member

@BrodyHughes BrodyHughes commented Jul 6, 2023 •
edited
Loading

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

Before:

║ ಡ ͜ ʖ ಡ ║2023-05-02 at 12 17 PM — Google Chrome

After:

Screen Shot 2023-07-06 at 4 13 34 PM

Screen recordings / screenshots

What to test

Final checklist

  • I have tested my changes in a LavaMoat bundle (yarn build).
  • I have tested my changes in Chrome & Brave.
  • If your changes are visual, did you check both the light and dark themes?

@linear
Copy link

linear bot commented Jul 6, 2023

BX-638 Corner radii on the QR code is wrong

║ ಡ ͜ ʖ ಡ ║2023-05-02 at 12.17 PM — Google Chrome.png

@BrodyHughes BrodyHughes marked this pull request as ready for review July 6, 2023 21:17
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-570fed5a1bff93067958e0cdbd26584c17f06e89.zip

@BrodyHughes BrodyHughes changed the title Fix BX-638 Fix BX-638 & BX-637 Jul 6, 2023
@linear
Copy link

linear bot commented Jul 6, 2023

BX-637 Wallet name on QR screen opens wallet switcher

This shouldnt happen.

example of bug: https://cln.sh/9RVqCTlk

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Here's the packed extension for this build:
rainbowbx-0b18fad50d7a57d3ebda078bb862bb9bf10ed5d8.zip

derHowie
derHowie requested changes Jul 6, 2023
View reviewed changes
src/entries/popup/pages/qrcode/index.tsx Outdated Show resolved Hide resolved
derHowie
derHowie approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! lgtm

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Here's the packed extension for this build:
rainbowbx-8c1b124d9749ac3f19acdfe4d45ecad561ec5a5f.zip

brunobar79
brunobar79 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝

@github-actions
Copy link

github-actions bot commented Jul 8, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-264acf71f812637a1782ee78f788ec394f04c318.zip

@github-actions
Copy link

github-actions bot commented Jul 8, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-b6ea84bcc40775a269f6fc3b0f941be226c68af6.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-66e1aca9dd669fdcce550fe10ba5354dba162886.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-e6f0c16a76f0764a2761501074c5d1fa17005a35.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-e6f0c16a76f0764a2761501074c5d1fa17005a35.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-e6f0c16a76f0764a2761501074c5d1fa17005a35.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-c4c77664a4bc139701d9e9452649f458801ee5fe.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-c4c77664a4bc139701d9e9452649f458801ee5fe.zip

@DanielSinclair DanielSinclair merged commit 3ad01e2 into master Jul 10, 2023
@DanielSinclair DanielSinclair deleted the brody/qr-code-radius branch July 10, 2023 20:29
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-3ad01e28fb9356aadc5a8f7f2f09a6fd024ef715.zip

@DanielSinclair DanielSinclair mentioned this pull request Jul 12, 2023
Merged
greg-schrammel pushed a commit that referenced this pull request Jul 13, 2023
@BrodyHughes @greg-schrammel
Fix BX-638 & BX-637 (#734)
d7dd3d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derHowie derHowie derHowie approved these changes

@brunobar79 brunobar79 brunobar79 approved these changes

@mikearndt mikearndt Awaiting requested review from mikearndt

@greg-schrammel greg-schrammel Awaiting requested review from greg-schrammel

@estebanmino estebanmino Awaiting requested review from estebanmino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BrodyHughes @brunobar79 @derHowie @DanielSinclair